Skip to content

fix(app): keep permission actions visible with long copy#15499

Open
BasharIQ wants to merge 1 commit intoanomalyco:devfrom
BasharIQ:fix/permission-dock-footer-overflow
Open

fix(app): keep permission actions visible with long copy#15499
BasharIQ wants to merge 1 commit intoanomalyco:devfrom
BasharIQ:fix/permission-dock-footer-overflow

Conversation

@BasharIQ
Copy link

Issue for this PR

Closes #15497

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Fixes a desktop UI bug where the permission modal could hide the action buttons (Reject, Allow always, Allow once) when the permission description was long (for example, "Run shell commands" in some locales or wrapped cases).
The fix does two things:

  1. Constrains permission prompt height to available dock space (same pattern used by the question prompt), so it does not grow past the visible area.
  2. Makes permission content scrollable with a small right padding so long text can scroll without colliding with the scrollbar.
    This keeps the footer actions visible and usable while still allowing long content to be read.

How did you verify your code works?

  • Reproduced the issue by triggering a permission request with long/wrapping description text.
  • Confirmed that before the change, footer buttons could be pushed out of view.
  • Confirmed after the change that footer buttons remain visible and content scrolls instead.
  • Ran package type checks for affected UI packages during validation.

Screenshots / recordings

Before: permission modal with long description and hidden footer actions
image

After: permission modal with visible Reject, Allow always, Allow once and scrollable content
image

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Permission modal hides action buttons when tool description wraps (desktop)

1 participant