Various changes to perf code

[Stevenjin8]

No description provided.

[istio-testing]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[ldemailly]

not sure what that example is but if ActualQPS is from fortio json, it's very unlikely to be a nice exact round number - if you ask for 1000 you're likely to get 999.97 or some such

[Stevenjin8]

I think my formatter might have caught this. Having the hard equals isn't great, I agree. But it gets rounded to an int, so if you run it for long enough, the actual qps ends up being the desired qps (most of the time).

[ldemailly]

not sure why it was using data["ActualQPS"] before but maybe comment on the change?
(also fortio data, in the json files, is in seconds not ms (even if the UI shows in ms for human consumption) so not sure what the 1000 is for either?

[Stevenjin8]

After some digging I think this is correct (but a comment would help). Fortio reports data in seconds, but the script that pull data from the fortio client converts it to microseconds

tools/perf/benchmark/runner/fortio.py

Lines 60 to 64 in 2030a1d

	p = h["Percentiles"]
	for pp in p:
	obj["p" + str(pp["Percentile"]).replace(".", "")
	] = int(pp["Value"] * 10 ** 6)

so I have to divide by 1000 to get it back to milliseconds

[istio-testing]

@Stevenjin8: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
gencheck_tools	2ee663f	link	true	/test gencheck
lint_tools	2ee663f	link	true	/test lint

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.