CLI terminal command handling to remove cd

[DonJayamanne]

Fixes microsoft/vscode#297967

[Copilot]

Pull request overview

Adjusts how Copilot CLI shell commands are presented to users by stripping redundant cd <workingDirectory> && (and PowerShell equivalents) when the cd target matches the known working directory, aligning with vscode#297967.

Changes:

• Exported and reused getCdPresentationOverrides to derive a user-friendly command line without a redundant cd prefix.
• Updated Copilot CLI tool-invocation formatting to apply the cd-stripping presentation logic.
• Added/updated unit tests to cover bash vs PowerShell patterns and workingDirectory matching behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/extension/agents/copilotcli/node/permissionHelpers.ts	Uses getCdPresentationOverrides to present a stripped command in terminal permission confirmations (with OS defaulting).
src/extension/agents/copilotcli/node/test/permissionHelpers.spec.ts	Adds coverage for stripping/keeping cd/Set-Location prefixes based on workingDirectory and Windows mode.
src/extension/agents/copilotcli/common/copilotCLITools.ts	Exports getCdPresentationOverrides and applies it while formatting shell tool invocation data.
src/extension/agents/copilotcli/common/test/copilotCLITools.spec.ts	Updates expectations around command-line data when cd stripping applies.

Comments suppressed due to low confidence (4)

src/extension/agents/copilotcli/common/test/copilotCLITools.spec.ts:601

• This assertion assumes commandLine.original is stripped, but ChatTerminalToolInvocationData documents stripping via presentationOverrides while keeping original intact. Update this test to reflect the corrected behavior (full command in original, stripped command in presentationOverrides).

			const data = completed.toolSpecificData as any;
			expect(data.commandLine.original).toBe('make build');
			expect(data.presentationOverrides).toEqual({ commandLine: 'make build' });
			expect(data.state.exitCode).toBe(0);

src/extension/agents/copilotcli/common/copilotCLITools.ts:836

• On Windows, isEqual here is case-sensitive (it’s bound to extUri), so cd C:\Workspace vs workingDirectory c:\workspace won’t match and the cd prefix won’t be stripped. Since this is file-path matching, consider using a casing-insensitive comparison (e.g. extUriBiasedIgnorePathCase.isEqual) or otherwise normalizing drive-letter/path casing before comparing.

export function getCdPresentationOverrides(commandLine: string, isPowershell: boolean, workingDirectory?: URI): { commandLine: string } | undefined {
	const cdPrefix = extractCdPrefix(commandLine, isPowershell);
	if (!cdPrefix || !workingDirectory) {
		return undefined;
	}
	const cdUri = URI.file(cdPrefix.directory);
	if (isEqual(cdUri, workingDirectory)) {
		return { commandLine: cdPrefix.command };

src/extension/agents/copilotcli/common/copilotCLITools.ts:853

• ChatTerminalToolInvocationData.commandLine.original is documented as the original/executed command, while presentationOverrides.commandLine is the UI-only stripped form. Overwriting original with the stripped command breaks that contract and can lose the real command for auditing/fallback UI. Keep commandLine.original as command (full input) and only set presentationOverrides when the cd prefix matches.

This issue also appears on line 863 of the same file.

	const presentationOverrides = getCdPresentationOverrides(command, isPowershell, workingDirectory);
	invocation.invocationMessage = args.description ? new MarkdownString(args.description) : '';
	invocation.toolSpecificData = {
		commandLine: {
			original: presentationOverrides?.commandLine ?? command
		},
		language: isPowershell ? 'powershell' : 'bash',
		presentationOverrides
	} as ChatTerminalToolInvocationData;

src/extension/agents/copilotcli/common/copilotCLITools.ts:869

• Same issue on completion: commandLine.original should remain toolCall.arguments.command and not be replaced by the presentation override. Use presentationOverrides.commandLine for the stripped display value only.

	const presentationOverrides = getCdPresentationOverrides(toolCall.arguments.command, isPowershell, workingDirectory);
	const toolSpecificData: ChatTerminalToolInvocationData = {
		commandLine: {
			original: presentationOverrides?.commandLine ?? toolCall.arguments.command
		},
		language: isPowershell ? 'powershell' : 'bash',
		presentationOverrides,